Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Deprecated for VPN Create #8

Closed
wants to merge 6 commits into from
Closed

Add Deprecated for VPN Create #8

wants to merge 6 commits into from

Conversation

michaelkad
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

ismirlia
ismirlia previously approved these changes Oct 20, 2023
View reviewed changes
@michaelkad
Copy link
Collaborator Author

Closing it's been merged.

@michaelkad michaelkad closed this Dec 26, 2023
@michaelkad michaelkad reopened this Mar 11, 2024
@michaelkad michaelkad closed this Mar 11, 2024
@michaelkad michaelkad deleted the remove_vpn_create branch May 28, 2024 18:59
michaelkad pushed a commit that referenced this pull request Jun 26, 2024
@kavya498 @niranjan-ibm
Support Cloud Logs data access rules (IBM-Cloud#5469)
9f8e9dc 
* add data-access-rule changes (#8)

* add data-access-rule changes

* update go mod and sum

* add docs

* modify test cases

* add tests

* add data-access-rule changes

* fix data access rules resource and datasource

---------

Co-authored-by: hkavya26 <hkavya26@in.ibm.com>

* remove commented line

---------

Co-authored-by: niranjan-ibm <143492258+niranjan-ibm@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ismirlia ismirlia ismirlia left review comments

@yussufsh yussufsh Awaiting requested review from yussufsh

@dhirendersingh19 dhirendersingh19 Awaiting requested review from dhirendersingh19

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michaelkad @ismirlia